-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webp support to Image Manipulation Class #3084
Conversation
It is possible for Imagemagick to support webp if it's compiled in so please make sure the Imagemagick handler also works with it or throws the error if not. |
@nicojmb we have two things to fix here:
@MGatner is there a way to sign the code right now, to make it mergeable? I think you showed me once some instructions but I didn't succeed make them work for me (it was probably my fault). So, I'm just wondering is there a way to "fix" this PR in this state. |
@michalsn you can add credentials to GitHub post-push and it will verify previous commits, but if the commits weren’t signed already that won’t work. Anyone could pull the fork, |
Can it be merged? This is something that is useful to me :) |
Right now we can't merge it since it's not signed and tests are failing. If nothing will change, I will probably wait till the weekend and try to fork this branch and re-commit. |
Yeah, the biggest problem is the tests. I am happy to override. And am thinking about removing that requirement, anyway, actually. |
Yes, removing the code signing requirement would probably be a good idea. |
Each pull request should address a single issue and have a meaningful title.
Description
Support webp image in Image Manipulation Class
Checklist:
---------Remove from here down in your description----------
Notes
(e.g. fixes 12345)
to the develop branch of the project repository