Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Composer files #3153

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jun 23, 2020

Description
This repo holds the master copies of composer.json for the other CodeIgniter 4 repositories and project launchers. A few fo them have become out of sync. This PR cleans them up and updates versions and names to be consistent.

Issues addressed:

  • Incorrect project name for framework
  • Missing dev requirements added since last release (faker, predis)
  • Missing script command "test"
  • Inconsistent PHPUnit version scheme (8.5.* standardized to ^8.5)
  • Inconsistent tabs/spaces standardized to tabs

Checklist:

  • Securely signed commits
  • n/a Component(s) with PHPdocs
  • n/a Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member

@MGatner could you normalize composer.json please, you can use composer-normalize for it https://github.com/ergebnis/composer-normalize

@jreklund
Copy link
Contributor

The only thing I can think of are require-dev block in framework. We don't include anything to my knowledge that require them. The user guide shows how to add phpunit manually, if you want to write tests for your application.

@michalsn
Copy link
Member

I think that the user guide mentions a --no-dev flag a couple of times, so I would go with a full list for require-dev. It's easier to have a full list than to search for the components you need later.

@MGatner
Copy link
Member Author

MGatner commented Jul 1, 2020

@samsonasik I ran them through the normalize tool - it looks like it just reordered alphabetically.

Re: require-dev on framework I would rather keep them because even if people don't use them it helps with package trackers to know related entries.

@MGatner MGatner requested a review from michalsn July 1, 2020 13:54
@michalsn michalsn merged commit b9940bb into codeigniter4:develop Jul 1, 2020
@MGatner MGatner deleted the composer-files branch April 6, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants