ArgType 'String' is not valid in MessageFormatter class (fixes #3191) #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First noticed when sending an email using the Email class, a few of the language strings in System/Language/en/*.php use an argtype of "string" which isn't valid in the PHP MessageFormatter class. This causes an error to be logged, or in a production environment, an error to be shown and the script halted. Removing this argType (leaving it undefined) fixes this completely.
There was also a typo in System/Language/en/Images.php in the same place (closing bracket instead of a closing brace) which I fixed at the same time.