Hide in bootstrap4 #3197
Merged
Hide in bootstrap4 #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the CSP policy is on, the style wouldn't work. So if the project use Bootstrap 4 or Bootstrap 3, it will be better to add thes classes.
|
Good point, but we can't accept hardcoded classes which work only with certain CSS framework. The proper way to solve this would be adding a new config variable to the Will you be able to make these changes? |
|
Ok, I tried, and make it simple as possible. |
michalsn
requested changes
Jul 3, 2020
The hiddenByClass is used for explicit what class to use for hide element. The hiddenContainer is template for sprintf
michalsn
requested changes
Jul 7, 2020
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
|
This small thing, and how long it takes :-D |
|
Thank you for taking care of this. I don't think we want to have a special CSS file shipped with the framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CSP policy is on, the style wouldn't work. So if the project use Bootstrap 4 or Bootstrap 3, it will be better to add thes classes.