Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Image::save() when target value is null #3268

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Fix Image::save() when target value is null #3268

merged 2 commits into from
Jul 11, 2020

Conversation

michalsn
Copy link
Member

Description
This PR fixes a bug when $target parameter in the save() method is null. We also take into consideration the $quality parameter for every case.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit ee0c554 into codeigniter4:develop Jul 11, 2020
@michalsn michalsn mentioned this pull request Jul 11, 2020
Closed
5 tasks
@michalsn michalsn deleted the fix/image_save branch July 16, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michalsn