Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hex2bin prefix handling for encryption key #3307

Merged
merged 5 commits into from
Jul 15, 2020
Merged

Add hex2bin prefix handling for encryption key #3307

merged 5 commits into from
Jul 15, 2020

Conversation

michalsn
Copy link
Member

Description
This PR adds support for 'hex2bin' prefix for $key variable from Encryption class. Both in PHP config and .env file.
See: #3297

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

michalsn and others added 3 commits July 15, 2020 06:57
@michalsn @samsonasik
Update system/Config/BaseConfig.php
f34f076 
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@michalsn @samsonasik
Update system/Config/DotEnv.php
cc6c07e 
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@michalsn
Test update
fff1510
@michalsn michalsn merged commit 69cff58 into codeigniter4:develop Jul 15, 2020
@michalsn michalsn deleted the encryption_key branch July 16, 2020 13:30
@paulbalandan paulbalandan mentioned this pull request Jul 16, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsn @samsonasik