Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix userguide config path #4057

Merged
merged 1 commit into from
Jan 3, 2021
Merged

fix userguide config path #4057

merged 1 commit into from
Jan 3, 2021

Conversation

totoprayogo1916
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 commented Jan 3, 2021 •
edited
Loading

Description
see:

CodeIgniter4/app/Config/Paths.php

Line 45 in 4ea15f8

public $appDirectory = __DIR__ . '/..';

CodeIgniter4/spark

Line 44 in 4ea15f8

require realpath('app/Config/Paths.php') ?: 'app/Config/Paths.php';

CodeIgniter4/public/index.php

Line 28 in 4ea15f8

require realpath(FCPATH . '../app/Config/Paths.php') ?: FCPATH . '../app/Config/Paths.php';

Checklist:

  • User guide updated
  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • Conforms to style guide

@paulbalandan paulbalandan merged commit 479b296 into codeigniter4:develop Jan 3, 2021
@totoprayogo1916 totoprayogo1916 deleted the userguide branch January 3, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totoprayogo1916 @paulbalandan