Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We’ve run into our first PHP 7/8 PHPStan issue: https://github.com/codeigniter4/CodeIgniter4/runs/1650630303
For whatever reason this line in CITestStreamFilter is no longer an issue in PHP 8, but persists in PHP 7:
Ondre is considering work on how to improve this split handling (phpstan/phpstan#4223 by our own @paulbalandan, phpstan/phpstan#4060 (comment)) but the current solution is to have different config files for each version.
Given that the problem currently is just single, small, test file I propose we ignore it for all versions and postpone dealing with this issue until we see what Ondre does upstream.
Checklist: