Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users on system messages being for internal use #4068

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Warn users on system messages being for internal use #4068

merged 1 commit into from
Jan 7, 2021

Conversation

paulbalandan
Copy link
Member

Checklist:

  • Securely signed commits

sfadschm
sfadschm approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@sfadschm sfadschm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message looks good.
I would have liked to see this in the UG, too. However, I read through the language section and there is no suitable place for such message as the system language strings are never mentioned. So I think adding such note might only cause confusion.

@paulbalandan paulbalandan merged commit 440ca29 into codeigniter4:develop Jan 7, 2021
@paulbalandan paulbalandan deleted the language-strings branch January 7, 2021 08:22
@MGatner MGatner mentioned this pull request Aug 23, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@sfadschm sfadschm sfadschm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @michalsn @sfadschm