Fix loss of escape value and data in the model

[michalsn]

Description
This PR tries to fix some issues with current Model behavior.

The main change is that $tempData['escape'] is no longer a boolean value but an array that holds all of the escape values for data. Since this variable is internal and wasn't never really used anywhere (in events for example), then I think changing it is fine.

After all, we're fixing a bug here. But if anyone sees a better idea to solve this, I'm all ears.

Fixes #4087

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

And I still don't understand why use 3 methods for insert / update in two classes
Model::insert() -> BaseModel::insert() -> Model::doInsert()

[iRedds]

Argument "?bool $escape = null" never used

When we use the foreach construct to call the set() method, we can use $this->escape directly and reset after the loop ends.

[najdanovicivan]

BaseModel Model->insert()

Public methods like this handles Object (Entity) to array conversion ,validation, protect fields, timestamp processing for created_at, updated_at, deleted_at and triggers the events,

Model doInsert() - Also defined as abstract in BaseModel

The actual database connection to read, insert, update data happens in methods prefixed with do which are called at the specific point from mentioned public methods

What's the reason behind all of this. If you wan't to create model for any other kind of database which was in my example MongoDB. You previously had to override or implement everything in the custom model. Now you can simply extend the BaseModel and do the custom db implementation by only implementing the abstract methods from the BaseModel. In practice this means that all the non DB related features will be available in the custom model including validation, protect fields, timestamps, conversion to entity objects, soft deletes, callbacks, pager ....

It might seam easier to complete model from scratch but this saves a lot of time by reusing already well documented and tested functionalities especially when you follow the complete DB driver structure using ConnectionInterface, QueryInterface and ResultInterface

[najdanovicivan]

@iRedds Thanks for the tip about the escape parameter I missed this one in #4072 so I submitted a new PR #4090

@michalsn can you check it out and rebase this one afterward ?

[iRedds]

For example, I want to change the BaseModel::update() method.
In this case, I need to inherit the new class from BaseModel and implement all abstract methods. Instead of just extending the Model with existing methods.

[najdanovicivan]

If you need to change the extend the update for SQL model you need to extend Model classs. Then you can either override the update or doUpdate depending on what you need

Extending BaseModel directly is only to be used when implementing Model class for custom database. eg. MongoDB, ElastecSearch, Firebase ...

[michalsn]

Thanks, @iRedds.

Thanks for making a PR @najdanovicivan, I missed it too. Please let me know if there are any issues with the proposed changes or if you see any place for improvements.