Add missing escaping in error_exception.php #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second argument of htmlspecialchars() is changed. ENT_IGNORE is never used. > Using this flag is discouraged as it » may have security implications. https://www.php.net/manual/en/function.htmlspecialchars.php
samsonasik
approved these changes
Jan 28, 2021
paulbalandan
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
error_exception.php.esc()in all places.I can not see the message containing
<...>.In the current code, some variables are escaped with
ENT_IGNORE, butI don't know why. It is not recommended, so I change esc()'s default.
Checklist: