Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UploadedFile::store() return type inconsistancy #4187

Merged
merged 1 commit into from
Jan 30, 2021
Merged

fix: UploadedFile::store() return type inconsistancy #4187

merged 1 commit into from
Jan 30, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 30, 2021

Description
Fixes #4183

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
fix: remove the code to return null
536e327 
$this->move() never returns false, but throws exception
@kenjis kenjis mentioned this pull request Jan 30, 2021
Closed
@paulbalandan paulbalandan merged commit cdf79cb into codeigniter4:develop Jan 30, 2021
@kenjis kenjis deleted the fix-4183 branch October 9, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: UploadedFile::store() can't return null
3 participants
@kenjis @michalsn @paulbalandan