Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes in Common.php #4192

Merged
merged 3 commits into from
Jan 30, 2021
Merged

Minor fixes in Common.php #4192

merged 3 commits into from
Jan 30, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 30, 2021 •
edited
Loading

Description

  • change confusing param name
  • add use for PHPDoc

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed Jan 30, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs update in the relevant user guide too.

@michalsn
Copy link
Member

Yes, the user guide has to be updated as well: https://codeigniter4.github.io/CodeIgniter4/general/common_functions.html#redirect

@kenjis
Copy link
Member Author

kenjis commented Jan 30, 2021

I've updated the user guide.

@paulbalandan paulbalandan merged commit 9ba38f4 into codeigniter4:develop Jan 30, 2021
@kenjis kenjis deleted the fix-Common branch February 1, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @paulbalandan