Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate cookie exception #4544

Merged
merged 13 commits into from
Apr 10, 2021
Merged

Relocate cookie exception #4544

merged 13 commits into from
Apr 10, 2021

Conversation

mostafakhudair
Copy link
Contributor

Finish Relocate Cookie Class #4502

paulbalandan
paulbalandan requested changes Apr 10, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the CookieException file in HTTP.

@mostafakhudair
Copy link
Contributor Author

@MGatner this PR need to be merged before the next release
@paulbalandan please review

@mostafakhudair
Copy link
Contributor Author

I deleted it, but forgot to save changes ^^

@paulbalandan
Copy link
Member

Waiting for tests..

@mostafakhudair
Copy link
Contributor Author

All green

@paulbalandan paulbalandan merged commit e8efe58 into codeigniter4:develop Apr 10, 2021
@mostafakhudair
Copy link
Contributor Author

@paulbalandan Thank you

@mostafakhudair mostafakhudair deleted the relocate-cookie-exception branch April 10, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mostafakhudair @paulbalandan