Debug/Toolbar - Memory issue fix

[najdanovicivan]

Description
This is the very simple method to avoid memory leak issue #4137 when entity objects with circular references are passed to the view.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[MGatner]

I like the concept but not the end result. We need to find some way to catch as much as we can. Does Kint (already included) not have some solution for this in place?

[najdanovicivan]

@MGatner I managed to make Kint work inside debug bar. The issue I had is that Kint render will return JS and CSS in as the string and since those are set as text via JS. The javascript from Kint will never be executed. So I had to play a bit with it to add the JS and CSS into the page head instead and then drop those when it's being rendered in the debug bar

[MGatner]

I'll take a look - if it is working then that's probably good. Kint also supports prefix modifiers to adjust the behavior - I think we could probably use ~ for "text output", or maybe @ to "return output". Play around with those and see what you think.

https://kint-php.github.io/kint/advanced/

[MGatner]

I think this should be fine. It definitely adds some complexity. See what you think of the text output option and if that is a worthy trade-off.

[najdanovicivan]

I am using @ prefix to return output. I tried text output as well but it looks nasty.

I was unable to make it work by chaining prefixes eg @~d() will not work for me.

Another problem with text output is it can get very long especially when controller is being passed to the view and if any of the variables contains HTML it may break the <pre> tag