Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Returns Types #4630

Merged
merged 2 commits into from
May 1, 2021
Merged

Cache Returns Types #4630

merged 2 commits into from
May 1, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Apr 30, 2021

Description
Adjusts a number of "mixed" return types to match their handler and User Guide specifications.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • n/a Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed May 1, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handlers' docblocks should be adjusted too.

@MGatner MGatner requested a review from paulbalandan May 1, 2021 12:55
MGatner
MGatner commented May 1, 2021
View reviewed changes
Copy link
Member Author

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, looks like I can make my own suggestions!

@MGatner
Copy link
Member Author

MGatner commented May 1, 2021

Nevermind the nevermind, you cannot commit a suggestion over a deleted line. I will get this fixed later.

@MGatner MGatner requested a review from paulbalandan May 1, 2021 14:58
@MGatner MGatner merged commit 13fd337 into codeigniter4:develop May 1, 2021
@MGatner MGatner deleted the cache-clean branch May 1, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @paulbalandan