Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scipts] Ensure admin/setup.sh exists before run bash admin/setup.sh #4650

Merged
merged 1 commit into from
May 6, 2021
Merged

[Scipts] Ensure admin/setup.sh exists before run bash admin/setup.sh #4650

merged 1 commit into from
May 6, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented May 6, 2021 •
edited
Loading

This ensure check admin/setup.sh exists before run it as admin directory is on .gitattributes.

CodeIgniter4/.gitattributes

Line 12 in 7546ee0

admin/ export-ignore

To avoid usage of download and run composer update with got error:

Script bash admin/setup.sh handling the post-update-cmd event returned with error code 127

Checklist:

  • Securely signed commits

MGatner
MGatner approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you've verified the escaping works as expected.

@samsonasik samsonasik merged commit c6efa26 into codeigniter4:develop May 6, 2021
@samsonasik samsonasik deleted the ensure-admin-setupexist branch May 6, 2021 14:17
@samsonasik
Copy link
Member Author

@MGatner thank you for the review.

@paulbalandan paulbalandan removed their request for review May 6, 2021 18:30
@paulbalandan paulbalandan mentioned this pull request May 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @MGatner