Refactor URI detection #4651
Merged
Refactor URI detection #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonnieezell
reviewed
May 10, 2021
lonnieezell
approved these changes
May 11, 2021
This was referenced Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stage One of an alternative to #4647, this PR refactors how
IncomingRequestdetects the "current URI" so that dependent functions and classes (namely, url_helper.php) will be more accurate.Note that some tests will likely fail due to #4116 (which has been deemed a bug) and will need to be updated. This likely means some developers will have issues as we work out this long-standing problem.(This will be a different PR)Fixes #3976
Note to reviewers: I reorganized the
IncomingRequestclass to a more logical order, which will make a mess of the review. Please view the first commit for a more helpful comparison.Checklist: