PSR: Cache #4667
Merged
PSR: Cache #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
force-pushed
the
psr-cache
branch
2 times, most recently
from
27c3461
to
4f2f932
Compare
lonnieezell
approved these changes
May 11, 2021
paulbalandan
approved these changes
May 11, 2021
|
@samsonasik any idea about this Rector error causing test failures? |
|
@MGatner please rebase and re-run composer update, it fixed at #4671 (comment) |
|
Ah great, thank you! I missed that - that's what I get for skipping my morning review 🙄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The core framework intentionally does not aim to meet all PSR interfaces, which for the most part works fine. Some PSR components allowing provisions for libraries and projects that complete the requirements. In this case, having adapters available in the framework itself can prevent CodeIgniter users from having to install additional third-party libraries that duplicate functionality.
This is the first PR to add adapters for PSR components, targeting Cache. There are two Cache PSR's from FIG:
These adapters sit on top of
CodeIgniter\Cache's handlers. Because of the additional layer the PSR adapters are not recommended for direct use except when the PSR interfaces are required.Tests are provided by php-cache who offers complete integration testing for PSR-6 and PSR-16 implementations.
Checklist: