Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure variable declarations #4737

Merged
merged 1 commit into from
May 25, 2021
Merged

Ensure variable declarations #4737

merged 1 commit into from
May 25, 2021

Conversation

jeromegamez
Copy link
Contributor

These changes ensure that variables definitely exist before accessing them, saving some @phpstan-ignore-lines.

:octocat:

@jeromegamez jeromegamez force-pushed the variable-declarations branch 2 times, most recently from 6723172 to 5ffeebe Compare May 24, 2021 21:37
@jeromegamez
Copy link
Contributor Author

I have no idea why the DateHelperTest::testNowSpecific() test fails 😭

@samsonasik
Copy link
Member

I re-run the gha

@samsonasik
Copy link
Member

All green 🎉 it seems ok 👍

MGatner
MGatner approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quality improvement here! 👍

@MGatner MGatner merged commit be99e5e into codeigniter4:develop May 25, 2021
@jeromegamez jeromegamez deleted the variable-declarations branch June 7, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeromegamez @samsonasik @MGatner @paulbalandan