Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional check for $argv variable when detecting CLI #4739

Merged
merged 1 commit into from
May 25, 2021
Merged

Additional check for $argv variable when detecting CLI #4739

merged 1 commit into from
May 25, 2021

Conversation

paulbalandan
Copy link
Member

Description
After checking existence of REMOTE_ADDR and HTTP_USER_AGENT keys in $_SERVER, additionally check if the $argv is set. Please note this will fail if the ini directive register_argv_argc is turned on for non-CLI requests.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@najdanovicivan
Copy link
Contributor

@paulbalandan This seems so solve the issue

@MGatner MGatner merged commit 94e0913 into develop May 25, 2021
@MGatner MGatner deleted the is-cli-detection branch May 25, 2021 15:15
@kenjis kenjis mentioned this pull request Dec 3, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@najdanovicivan najdanovicivan najdanovicivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @najdanovicivan @MGatner