Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rector] Apply Rector: MoveVariableDeclarationNearReferenceRector #4752

Merged
merged 1 commit into from
May 30, 2021
Merged

[Rector] Apply Rector: MoveVariableDeclarationNearReferenceRector #4752

merged 1 commit into from
May 30, 2021

Conversation

samsonasik
Copy link
Member

Move variable declaration near its reference with MoveVariableDeclarationNearReferenceRector rector rule. It needs latest rector 0.11.7. I updated phpstan/phpstan to 0.12.88 as well.

Checklist:

  • Securely signed commits

@samsonasik
Copy link
Member Author

PHPUnit notice seems unrelated:

1) CodeIgniter\Images\ImageMagickHandlerTest::testText
486
CodeIgniter\Images\Exceptions\ImageException: Image processing failed. Please verify that your server supports the chosen protocol and that the path to your image library is correct.

@MGatner
Copy link
Member

MGatner commented May 30, 2021

Something is happening with Image Magick, causing all tests to fail. We'll have to look into that soon.

@samsonasik samsonasik merged commit b0552ba into codeigniter4:develop May 30, 2021
@samsonasik samsonasik deleted the apply-rector-move-variable branch May 30, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @MGatner @paulbalandan