-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Copy-Paste Detector #5031
PHP Copy-Paste Detector #5031
Conversation
Something is disturbingly wrong that this has effected non-SQLSRV tests. Anyone have guesses? @michalsn? |
I don't know why, but the test (
|
When calling the CodeIgniter4/system/Database/BaseBuilder.php Line 590 in dae39bf
Then in the rest of the changed method, the same (now correct) join (using getFullName ) is appended to QBJoin as well:
Also, currently, this part is executed twice (in the parent and in the child): CodeIgniter4/system/Database/SQLSRV/Builder.php Lines 97 to 100 in dae39bf
I think if you want to do this properly, you will have to split the duplicate part out into a helper method of the BaseBuilder .
Edit: This would then need to return the |
Thanks all. As @kenjis pointed out, the code in |
Description
This is a new tool I'm using at work from Sebastian Bergmann (PHPUnit author) that I thought would make a nice addition to the CS Fixer changes were are rolling out soon. The only remaining violation (ignoring tests/ for now) is in
Database\\SQLSRV\\Builder::coompileSelect()
but refactoring that is beyond the current scope ofdevelop
so I have ignored the file for now.Checklist: