Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the problem that _createTable does not take into account that it returns true. #5133

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Fixed the problem that _createTable does not take into account that it returns true. #5133

merged 1 commit into from
Sep 26, 2021

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented Sep 26, 2021 •
edited by kenjis
Loading

Fixed the problem that _createTable does not take into account that it returns true.

Description

If _createTable returns true, then createTable will return true.
This occurs only when the createTableIfStr property is false in the Forge class.
I had trouble with this behavior when I was creating the OCI8 driver.

see: #2487 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ytetsuro ytetsuro force-pushed the fix/createTable_fails_when_the_table_exists branch from f564f6b to 4aa04fb Compare September 26, 2021 01:58
kenjis
kenjis approved these changes Sep 26, 2021
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenjis kenjis added the database Issues or pull requests that affect the database layer label Sep 26, 2021
@lonnieezell lonnieezell merged commit 4649204 into codeigniter4:develop Sep 26, 2021
@kenjis kenjis mentioned this pull request Sep 26, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytetsuro @kenjis @lonnieezell