-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when value is an object - validating api data #5142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example: { "configuration" : { "consumerKey1" : "aa", "consumerSecret" : "bb", "oauthToken" : "cc", "oauthTokenSecret" : "dd" } }
Please provide unit test and run cs fix:
|
Done. |
please run cs fix |
Done, sorry.
El mar, 28 sept 2021 a las 14:50, Abdul Malik Ikhsan (<
***@***.***>) escribió:
… please run cs fix
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5142 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ5DPZUYWTLJJHW6D2BISLUEG2YNANCNFSM5E2RNU7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Done, sorry. |
ok,
|
kenjis
reviewed
Sep 28, 2021
If you try to validate an object and it fails, the application fails
because it only accepts strings and arrays, it does not do a
json_encode if it is an object, because when you work with rest, you
may have to validate objects.
…On Wed, 29 Sep 2021, 16:48 John Paul E. Balandan, CPA, < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/system/Validation/ValidationTest.php
<#5142 (comment)>
:
> + $data = (object) ['configuration' => (object) ['first' => 1, 'second' => 2]];
+ $this->validation->run((array) $data);
Hmm. Fair enough. Thanks for the explanation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5142 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ5DPYBOBG5OGAKCANSHGDUEMRK5ANCNFSM5E2RNU7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
paulbalandan
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
Description
Explain what you have changed, and why.
Checklist: