Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when value is an object - validating api data #5142

Merged
merged 6 commits into from
Oct 1, 2021
Merged

Error when value is an object - validating api data #5142

merged 6 commits into from
Oct 1, 2021

Conversation

daycry
Copy link
Contributor

@daycry daycry commented Sep 27, 2021

For example:

{
	"configuration" :
        {
	        "consumerKey1" : "aa",
	        "consumerSecret" : "bb",
	        "oauthToken" : "cc",
	        "oauthTokenSecret" : "dd"
        }
}

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

For example:

{
	"configuration" :
		{
			"consumerKey1" : "aa",
			"consumerSecret" : "bb",
			"oauthToken" : "cc",
			"oauthTokenSecret" : "dd"
		}
}
@samsonasik
Copy link
Member

Please provide unit test and run cs fix:

vendor/bin/php-cs-fixer fix system/Validation/Validation.php

@samsonasik samsonasik added the tests needed Pull requests that need tests label Sep 27, 2021
@daycry
Copy link
Contributor Author

daycry commented Sep 28, 2021

Done.

@samsonasik
Copy link
Member

please run cs fix

@daycry
Copy link
Contributor Author

daycry commented Sep 28, 2021 via email

@daycry
Copy link
Contributor Author

daycry commented Sep 28, 2021

Done, sorry.

@samsonasik samsonasik removed the tests needed Pull requests that need tests label Sep 28, 2021
@samsonasik
Copy link
Member

@daycry
Copy link
Contributor Author

daycry commented Sep 28, 2021

ok,
I have launched the processes for fix it

  • vendor/bin/php-cs-fixer fix .\tests\system\Validation\ValidationTest.php
  • vendor/bin/php-cs-fixer fix .\tests_support\Validation\TestRules.php

@daycry
Copy link
Contributor Author

daycry commented Sep 29, 2021 via email

@paulbalandan paulbalandan merged commit 9c07842 into codeigniter4:develop Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants