Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FileLocator cannot find files in sub-namespaces of the same vendor #5292

Merged
merged 1 commit into from
Nov 11, 2021
Merged

fix: FileLocator cannot find files in sub-namespaces of the same vendor #5292

merged 1 commit into from
Nov 11, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 8, 2021

Description
FileLocator cannot find files in sub-namespaces of the same vendor.
For example, when you have CodeIgniter and CodeIgniter\Devkit.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title fix: cannot find files in sub-namespaces of the same vendor fix: FileLocator cannot find files in sub-namespaces of the same vendor Nov 8, 2021
@kenjis
fix: cannot find files in sub-namespaces of the same vendor
5bf6d51 
For example, when you have `CodeIgniter` and `CodeIgniter\Devkit`.
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 9, 2021
@kenjis kenjis merged commit 8f86199 into codeigniter4:develop Nov 11, 2021
@kenjis kenjis deleted the fix-locateFile branch November 11, 2021 11:31
@kenjis kenjis mentioned this pull request Nov 14, 2021
Closed
@kenjis kenjis mentioned this pull request Apr 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan