Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display file:line and trace information to database queries in debug toolbar #5334

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

lonnieezell
Copy link
Member

@lonnieezell lonnieezell commented Nov 16, 2021

Added backtrace information and the file:line of each query into the Database pane of the debug toolbar. The backtrace is hidden by default but opens by clicking on the row.

Screen Shot 2021-11-15 at 12 51 16 AM

@kenjis kenjis added the enhancement PRs that improve existing functionalities label Nov 16, 2021
@sfadschm
Copy link
Contributor

sfadschm commented Nov 16, 2021

looks nice!
on second thought I am not sure if the backtrace gives so much valuable information here compared to the line where the query was fired. if #5162 gets implemented, all info together could get a little confusing

@MGatner
Copy link
Member

MGatner commented Nov 16, 2021

Looks good! I think the Rector change is relevant but after that everything looks shipshape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants