Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: PHPStan stubs for model() #5418

Closed
wants to merge 2 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 1, 2021

Description
Ref #5358

This does not work.

$ composer analyze
> phpstan analyse
Note: Using configuration file /Users/kenji/work/codeigniter/CodeIgniter4/phpstan.neon.dist.
 405/405 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------- 
  Line   system/Common.php                                                           
 ------ ---------------------------------------------------------------------------- 
  782    Call to an undefined static method CodeIgniter\Config\Factories::models().  
  782    Function model() should return T of CodeIgniter\Model but returns mixed.    
 ------ ---------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------- 
  Line   system/Database/ModelFactory.php                                            
 ------ ---------------------------------------------------------------------------- 
  32     Call to an undefined static method CodeIgniter\Config\Factories::models().  
 ------ ----------------------------------------------------------------------------

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft December 1, 2021 00:18
@kenjis kenjis closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant