Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: KINT visual error when activating CSP #5501

Merged
merged 2 commits into from
Dec 30, 2021
Merged

fix: KINT visual error when activating CSP #5501

merged 2 commits into from
Dec 30, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 25, 2021 •
edited
Loading

Description
Supersede #5482
Fixes #5475

  • overrides RichRenderer::preRender()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 25, 2021
This was referenced Dec 25, 2021
Closed
Closed
lonnieezell
lonnieezell approved these changes Dec 26, 2021
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution from what I understand of Kint's internals.

MGatner
MGatner reviewed Dec 26, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better! Does this require the Kint files published to system or will it work with a regular Composer installation too?

@sfadschm
Copy link
Contributor

This looks much better! Does this require the Kint files published to system or will it work with a regular Composer installation too?

The autoloader adds Composer namespaces last, so this should work for this case. The Kint files in the ThirdParty folder should also be loaded after the regular system folder.

@kenjis
Copy link
Member Author

kenjis commented Dec 29, 2021

@MGatner This PR just overrides a Kint method. It should work with a regular Composer installation and Zip installation.

@kenjis kenjis merged commit 5ed6211 into codeigniter4:develop Dec 30, 2021
@kenjis kenjis deleted the fix-kint-RichRenderer branch December 30, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: KINT d() visual error in debugging when activating CSP
4 participants
@kenjis @sfadschm @lonnieezell @MGatner