Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Toolbar. ciDebugBar.showTab() context. #5554

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Fix: Toolbar. ciDebugBar.showTab() context. #5554

merged 1 commit into from
Jan 7, 2022

Conversation

iRedds
Copy link
Collaborator

@iRedds iRedds commented Jan 7, 2022 •
edited by kenjis
Loading

Description
Follow-up #5544
Calling the showTab method changes the context if the method is not called directly, but as an "internal call".
Rollback of previous changes.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 7, 2022
kenjis
kenjis approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked. Thanks!

@kenjis kenjis added the hotfix label Jan 7, 2022
@paulbalandan paulbalandan merged commit a09f7d9 into codeigniter4:develop Jan 7, 2022
kenjis pushed a commit that referenced this pull request Jan 8, 2022
@paulbalandan @kenjis
Merge pull request #5554 from iRedds/fix/toolbar
c058b18 
Fix: Toolbar. ciDebugBar.showTab() context.
@kenjis kenjis mentioned this pull request Jan 8, 2022
Merged
8 tasks
@iRedds iRedds deleted the fix/toolbar branch January 8, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iRedds @kenjis @paulbalandan