Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added alias escaping in subquery #5601

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Fix: Added alias escaping in subquery #5601

merged 2 commits into from
Jan 23, 2022

Conversation

iRedds
Copy link
Collaborator

@iRedds iRedds commented Jan 20, 2022 •
edited by kenjis
Loading

Description
Follow-up #5510
Added alias escaping in subquery

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 22, 2022
@kenjis
Copy link
Member

kenjis commented Jan 22, 2022

Do you update the user guide?

@iRedds
Copy link
Collaborator Author

iRedds commented Jan 22, 2022

@kenjis
I didn't attach importance to it. Now I'll add alias escaping.
It would be desirable to learn, into the account of the correct registration of SQL in the documentation. Because some of the SQL examples don't use escaping.

@iRedds
Fix: Escaping subquery alias docs
d8406d9 
Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
@kenjis kenjis merged commit 9642cca into codeigniter4:develop Jan 23, 2022
@iRedds iRedds deleted the fix/subquery-alias branch February 4, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iRedds @kenjis @paulbalandan