Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: generate coverage report by PHPUnit only on PHP 8.0 #5604

Merged
merged 2 commits into from
Jan 21, 2022
Merged

chore: generate coverage report by PHPUnit only on PHP 8.0 #5604

merged 2 commits into from
Jan 21, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 21, 2022 •
edited
Loading

Description

  • To reduce test time
    • add --no-coverage option to PHPUnit other than on PHP 8.0

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Jan 21, 2022
@kenjis @paulbalandan
chore: compute phpunit option for coverage
ed67dcc 
Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
@kenjis
Copy link
Member Author

kenjis commented Jan 21, 2022

PHPUnit / PHP 7.4 & 8.1 testing finished in 3m to 6m!

@kenjis kenjis merged commit 812af1e into codeigniter4:develop Jan 21, 2022
@kenjis kenjis deleted the fix-workflows/test-phpunit branch January 21, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan