Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DownloadResponse memory leak #5623

Merged
merged 2 commits into from
Jan 29, 2022
Merged

fix: DownloadResponse memory leak #5623

merged 2 commits into from
Jan 29, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 27, 2022

Description
Fixes #5620

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 27, 2022
@kenjis kenjis mentioned this pull request Jan 27, 2022
Closed
@samsonasik samsonasik requested a review from MGatner January 27, 2022 01:42
@MGatner
Copy link
Member

MGatner commented Jan 27, 2022

I will try this on desktop.

MGatner
MGatner approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and this fixes the issue on the test repo! Embarrassing how small that was for how long I've been dealing with this 😅

@samsonasik samsonasik merged commit 25f60cc into codeigniter4:develop Jan 29, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-download-memory-leak branch January 30, 2022 00:54
@kenjis kenjis mentioned this pull request May 18, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: DownloadResponse Fails with Large Files
4 participants
@kenjis @MGatner @samsonasik @paulbalandan