Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: small changes in Filters and Router #5627

Merged
merged 2 commits into from
Jan 29, 2022
Merged

refactor: small changes in Filters and Router #5627

merged 2 commits into from
Jan 29, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 28, 2022

Description

  • initialize property
  • renumber the array keys

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jan 28, 2022
@kenjis kenjis merged commit bafd425 into codeigniter4:develop Jan 29, 2022
@kenjis kenjis deleted the fix-router-filter branch January 29, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan