Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: $builder->ignore()->insertBatch() only ignores on first iteration #5672

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix: $builder->ignore()->insertBatch() only ignores on first iteration #5672

merged 1 commit into from
Mar 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 10, 2022

Description
Fixes #5671

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Feb 10, 2022
@kenjis kenjis mentioned this pull request Feb 10, 2022
Closed
@kenjis kenjis merged commit 5de4168 into codeigniter4:develop Mar 1, 2022
@kenjis kenjis deleted the fix-QB-insertBatch-ignore branch March 1, 2022 23:37
@kenjis
Copy link
Member Author

kenjis commented Mar 1, 2022

@samsonasik Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iRedds iRedds iRedds left review comments

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: $builder->ignore()->insertBatch() only ignores on first iteration of batch
3 participants
@kenjis @samsonasik @iRedds