fix: $routes->setDefaultMethod() does not work #5682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
|
Wrong approach. |
|
Removed |
kenjis
force-pushed
the
fix-router-default-method
branch
from
3488391
to
7facfb0
Compare
The default method may be not `index`, and it is set in the constructor.
The constructor of the Router class already defines the default controller.
kenjis
force-pushed
the
fix-router-default-method
branch
from
7facfb0
to
2822a18
Compare
|
Removing a protected method is a breaking change. I reverted |
system/Router/Router.php
Outdated
| @@ -646,8 +640,6 @@ protected function setRequest(array $segments = []) | |||
| { | |||
| // If we don't have any segments - try the default controller; | |||
There was a problem hiding this comment.
This comment is no longer true
There was a problem hiding this comment.
Indeed. "try" is strange.
Updated.
| if (empty($segments)) { | ||
| $this->setDefaultController(); | ||
| } | ||
| // If we don't have any segments left - use the default controller; |
There was a problem hiding this comment.
I think this comment should also be removed?
There was a problem hiding this comment.
It is true. I don't think to be removed.
Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
paulbalandan
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
$routes->setDefaultMethod()does not work when you go to/See https://forum.codeigniter.com/thread-81269.html
Checklist: