Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: debug toolbar vars response headers includes request headers #5701

Merged
merged 4 commits into from
Feb 17, 2022
Merged

fix: debug toolbar vars response headers includes request headers #5701

merged 4 commits into from
Feb 17, 2022

Conversation

zl59503020
Copy link
Contributor

@zl59503020 zl59503020 commented Feb 16, 2022 •
edited by kenjis
Loading

update debug toolbar vars response header

Description
update debug toolbar vars response header no repeat request header

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member

kenjis commented Feb 17, 2022

@zl59503020 Can you fix the coding style?

@kenjis
Copy link
Member

kenjis commented Feb 17, 2022

Before:
Screenshot 2022-02-17 10 03 28

After:
Screenshot 2022-02-17 10 03 37

@zl59503020
Copy link
Contributor Author

@zl59503020你能修复编码风格吗？

ok

@kenjis
Copy link
Member

kenjis commented Feb 17, 2022

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#php-style

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 17, 2022
@kenjis kenjis changed the title update debug toolbar vars response header fix: debug toolbar vars response headers includes request headers Feb 17, 2022
@samsonasik samsonasik merged commit f8267cb into codeigniter4:develop Feb 17, 2022
@samsonasik
Copy link
Member

Thank you @zl59503020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zl59503020 @kenjis @samsonasik