Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table name is double prefixed when LIKE clause #5778

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 6, 2022

Description
Fixes #5775

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Mar 6, 2022
@iRedds
Copy link
Collaborator

iRedds commented Mar 6, 2022

Double escaping when using the LIKE clause.

$likeStatement = $this->_like_statement($prefix, $this->db->protectIdentifiers($k, false, $escape), $not, $bind, $insensitiveSearch);

$condition = $matches[1] . $this->db->protectIdentifiers(trim($matches[2]))

Does it make sense?

@kenjis
Copy link
Member Author

kenjis commented Mar 6, 2022

It is from #5170.
We might have made a mistake.
We need to reconsider.

@kenjis
Copy link
Member Author

kenjis commented Mar 7, 2022

Removed double escape.

@samsonasik samsonasik merged commit 7e763f5 into codeigniter4:develop Mar 8, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: table has double prefix when LIKE clause
3 participants