Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Pager] can't get correct current page from segment #5803

Merged
merged 7 commits into from
Mar 18, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 16, 2022

Description
From https://forum.codeigniter.com/thread-81531.html

  • setSegment() recalculates the current page
  • calculateCurrentPage() can be called more than once

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 16, 2022
@samsonasik samsonasik merged commit 92eb705 into codeigniter4:develop Mar 18, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-pager branch March 18, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants