Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Validation] valid_date ErrorException when the field is not sent #5804

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix: [Validation] valid_date ErrorException when the field is not sent #5804

merged 2 commits into from
Mar 16, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 16, 2022 •
edited
Loading

Description
From https://forum.codeigniter.com/thread-81505-post-394652.html

DateTime::createFromFormat(): Passing null to parameter #2 ($datetime) of type string is deprecated

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 16, 2022
@kenjis kenjis changed the title fix: [Validation] valid_date TypeError when the field is not sent fix: [Validation] valid_date ErrorException when the field is not sent Mar 16, 2022
@kenjis
fix: ErrorException when the field is not sent
e954172 
ErrorException
DateTime::createFromFormat(): Passing null to parameter #2 ($datetime) of type string is deprecated
@kenjis kenjis merged commit 479a155 into codeigniter4:develop Mar 16, 2022
@kenjis kenjis deleted the fix-valid-date branch March 16, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan