Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spark can't use options on PHP 7.4 #5836

Merged
merged 3 commits into from
Mar 30, 2022
Merged

fix: spark can't use options on PHP 7.4 #5836

merged 3 commits into from
Mar 30, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 28, 2022 •
edited
Loading

Description
Fixes #5835
Follow-up #5206

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Mar 28, 2022
@kenjis kenjis force-pushed the fix-spark-options-php74 branch from 6efb121 to 9e1a0f9 Compare March 28, 2022 03:36
@MGatner
Copy link
Member

MGatner commented Mar 28, 2022

I'm okay with this breaking change given that it is inherently bugged.

kenjis added 3 commits March 30, 2022 19:12
@kenjis
fix: spark can't use options in PHP 7.4
78d42a5 
Cannot unpack array with string keys
at SYSTEMPATH/CodeIgniter.php:893
@kenjis
refactor: remove unneeded logic
9cade91 
It seems out of dated logic.
@kenjis
docs: add CommandRunner::_remap() change in changelogs
d0b323d
@kenjis kenjis force-pushed the fix-spark-options-php74 branch from 9e1a0f9 to d0b323d Compare March 30, 2022 10:17
@kenjis
Copy link
Member Author

kenjis commented Mar 30, 2022

Added changelog.

@kenjis kenjis requested review from samsonasik and MGatner March 30, 2022 10:21
MGatner
MGatner approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@kenjis kenjis merged commit 2fa236c into codeigniter4:develop Mar 30, 2022
@kenjis kenjis deleted the fix-spark-options-php74 branch March 30, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Spark cannot use Сommand option on PHP 7.4 (Cannot unpack array with string keys)
3 participants
@kenjis @MGatner @samsonasik