Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parser fails with ({variable}) in loop #5840

Merged
merged 2 commits into from
Apr 12, 2022
Merged

fix: Parser fails with ({variable}) in loop #5840

merged 2 commits into from
Apr 12, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 30, 2022

Description
Fixes #5825

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 30, 2022
@kenjis kenjis mentioned this pull request Mar 30, 2022
Closed
MGatner
MGatner approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a far superior approach to the original code. If you feel confident preg_quote() covers all the removed cases then this is a great improvement.

@kenjis
Copy link
Member Author

kenjis commented Apr 12, 2022

preg_quote() escapes all meta characters in regexp.

@kenjis kenjis merged commit b5486a4 into codeigniter4:develop Apr 12, 2022
@kenjis kenjis deleted the fix-parser branch April 12, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: view parser fails with ({variable}) in loop
2 participants
@kenjis @MGatner