Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Parser] add configs to change conditional delimiters #5842

Merged
merged 2 commits into from
Apr 2, 2022
Merged

feat: [Parser] add configs to change conditional delimiters #5842

merged 2 commits into from
Apr 2, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 31, 2022 •
edited
Loading

Description
Fixes #5831

  • add properties $leftConditionalDelimiter and $rightConditionalDelimiter
  • add method setConditionalDelimiters()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Mar 31, 2022
Closed
5 tasks
@kenjis kenjis added enhancement PRs that improve existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them labels Mar 31, 2022
@kenjis kenjis mentioned this pull request Mar 31, 2022
Closed
MGatner
MGatner approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant solution. I'd like someone who actually uses the View Parser to review as well (if we have one available).

@kenjis kenjis merged commit e075dbf into codeigniter4:develop Apr 2, 2022
@kenjis kenjis deleted the feat-parser-conditional-delimiter branch April 2, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: View parser throws view exception with nested 'if' within javascript code
3 participants
@kenjis @MGatner @paulbalandan