Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add $includeDir option to get_filenames() #5862

Merged
merged 3 commits into from
Apr 6, 2022
Merged

feat: add $includeDir option to get_filenames() #5862

merged 3 commits into from
Apr 6, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 5, 2022 •
edited
Loading

Description

  • add option to exclude directories

See #5849 (comment) and

CodeIgniter4/tests/system/Helpers/FilesystemHelperTest.php

Lines 290 to 291 in 8f1ed45

// Not sure the directory names should actually show up
// here but this matches v3.x results.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the enhancement PRs that improve existing functionalities label Apr 5, 2022
paulbalandan
paulbalandan reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include this change in the changelogs

user_guide_src/source/helpers/filesystem_helper.rst Outdated Show resolved Hide resolved
kenjis and others added 2 commits April 6, 2022 17:33
@kenjis @paulbalandan
docs: fix by proofreading
606518a 
Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
@kenjis
docs: add changelog
3fe7b8a
@kenjis
Copy link
Member Author

kenjis commented Apr 6, 2022

Added to changelog.

@kenjis kenjis merged commit ad9d1ba into codeigniter4:develop Apr 6, 2022
@kenjis kenjis deleted the feat-get_filenames-includeDir branch April 6, 2022 22:50
@datamweb
Copy link
Contributor

[kenjis] I just wanted to thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @paulbalandan