Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: QueryBuilder join() raw SQL string support #5875

Merged
merged 5 commits into from
May 24, 2022
Merged

feat: QueryBuilder join() raw SQL string support #5875

merged 5 commits into from
May 24, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 7, 2022 •
edited
Loading

Needs to rebase after merging #5817

Related #3832

Description

  • join() supports RawSql

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft April 7, 2022 10:09
@kenjis kenjis added enhancement PRs that improve existing functionalities breaking change Pull requests that may break existing functionalities labels Apr 7, 2022
@MGatner MGatner added the database Issues or pull requests that affect the database layer label Apr 10, 2022
lonnieezell
lonnieezell requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but does need docs, like 5817

@kenjis kenjis force-pushed the feat-qb-raw-sql-join branch from 8d1ac3e to ea25d22 Compare May 4, 2022 01:39
@kenjis kenjis mentioned this pull request May 4, 2022
Merged
4 tasks
@kenjis kenjis force-pushed the feat-qb-raw-sql-join branch from ea25d22 to 74df728 Compare May 4, 2022 06:45
@kenjis kenjis marked this pull request as ready for review May 4, 2022 07:15
@kenjis kenjis requested a review from lonnieezell May 4, 2022 07:15
@kenjis
Copy link
Member Author

kenjis commented May 4, 2022

Added the docs.

@kenjis kenjis force-pushed the feat-qb-raw-sql-join branch from ffced53 to 2bcd55b Compare May 6, 2022 07:10
@kenjis kenjis force-pushed the feat-qb-raw-sql-join branch from 2bcd55b to ae40b35 Compare May 19, 2022 23:03
@kenjis
Copy link
Member Author

kenjis commented May 19, 2022

Rebased.
Please review.

@kenjis kenjis merged commit daff2d7 into codeigniter4:develop May 24, 2022
@kenjis kenjis deleted the feat-qb-raw-sql-join branch May 24, 2022 06:40
@kenjis
Copy link
Member Author

kenjis commented May 24, 2022

@michalsn Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@lonnieezell lonnieezell Awaiting requested review from lonnieezell

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities database Issues or pull requests that affect the database layer enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @lonnieezell @michalsn @MGatner