Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new improved auto router #5889

Merged
merged 30 commits into from
May 3, 2022
Merged

feat: new improved auto router #5889

merged 30 commits into from
May 3, 2022

Commits on May 3, 2022

  1. feat: add AutoRouterImproved class

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    680f9ff View commit details
    Browse the repository at this point in the history

  2. feat: add param checking

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    fd4f9b8 View commit details
    Browse the repository at this point in the history

  3. test: add test for POST method

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a5f8d80 View commit details
    Browse the repository at this point in the history

  4. refactor: improve exception messages

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    bdac511 View commit details
    Browse the repository at this point in the history

  5. refactor: fix classnames and method names 

    Follow auto routing naming conventions.
    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    d7d5174 View commit details
    Browse the repository at this point in the history

  6. test: rename Controllers/Test 

    It is better not to use sample controller class `Test` in tests/ folder.
    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    b691387 View commit details
    Browse the repository at this point in the history

  7. feat: AutoRouterImproved does not support _remap() 

    It makes the router complex.
    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    dcd8ba7 View commit details
    Browse the repository at this point in the history

  8. refactor: extract protectDefinedCliRoutes() method

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    8e89710 View commit details
    Browse the repository at this point in the history

  9. fix: update __construct() and protectDefinedCliRoutes() in AutoRouter… 

    …Improved
    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    f0f212b View commit details
    Browse the repository at this point in the history

  10. chore: updatte phpstan-baseline.neon.dist

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    3fd4182 View commit details
    Browse the repository at this point in the history

  11. docs: add @var

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    ddfa0d7 View commit details
    Browse the repository at this point in the history

  12. refactor: rename method name

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    c253b61 View commit details
    Browse the repository at this point in the history

  13. test: fix tests

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a090a64 View commit details
    Browse the repository at this point in the history

  14. refactor: vendor/bin/rector process

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    8f3365a View commit details
    Browse the repository at this point in the history

  15. refactor: add return types

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    9fc97e7 View commit details
    Browse the repository at this point in the history

  16. test: remove using BaseController because of rector's error 

    Error: ] Could not process "tests/system/Router/AutoRouterImprovedTest.php"
         file, due to:
         "System error: "Class 'App\Controllers\BaseController' not found"
         Run Rector with "--debug" option and post the report here:
         https://github.com/rectorphp/rector/issues/new". On line: 16
    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    3cff22c View commit details
    Browse the repository at this point in the history

  17. refactor: vendor/bin/rector process

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    c8b1e41 View commit details
    Browse the repository at this point in the history

  18. test: fix tests that rector broke

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    e6eaf71 View commit details
    Browse the repository at this point in the history

  19. fix: protectDefinedRoutes() 

    Remove unneeded if condition.
Fix exception message.
    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    97dcb46 View commit details
    Browse the repository at this point in the history

  20. docs: improve doc comment

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    6d6ad00 View commit details
    Browse the repository at this point in the history

  21. refactor: add final to new classes that implements AutoRouterInterface

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    6e454e5 View commit details
    Browse the repository at this point in the history

  22. docs: add @deprecated

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    0ec9c06 View commit details
    Browse the repository at this point in the history

  23. refactor: add property type 

    Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @kenjis @samsonasik
    kenjis and samsonasik committed May 3, 2022
    Configuration menu
    Copy the full SHA
    83c4342 View commit details
    Browse the repository at this point in the history

  24. docs: composer cs-fix

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    56f183c View commit details
    Browse the repository at this point in the history

  25. docs: add docs

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    061984a View commit details
    Browse the repository at this point in the history

  26. docs: fix by proofreading 

    Co-authored-by: MGatner <mgatner@icloud.com>
    @kenjis @MGatner
    kenjis and MGatner committed May 3, 2022
    Configuration menu
    Copy the full SHA
    2639a7f View commit details
    Browse the repository at this point in the history

  27. docs: fix typo 

    Co-authored-by: MGatner <mgatner@icloud.com>
    @kenjis @MGatner
    kenjis and MGatner committed May 3, 2022
    Configuration menu
    Copy the full SHA
    7b087b2 View commit details
    Browse the repository at this point in the history

  28. docs: fix by proofreading 

    Co-authored-by: MGatner <mgatner@icloud.com>
    @kenjis @MGatner
    kenjis and MGatner committed May 3, 2022
    Configuration menu
    Copy the full SHA
    9e09097 View commit details
    Browse the repository at this point in the history

  29. docs: replace Traditional with Legacy for auto-routing

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    70f62aa View commit details
    Browse the repository at this point in the history

  30. test: run rector

    @kenjis
    kenjis committed May 3, 2022
    Configuration menu
    Copy the full SHA
    2fe5107 View commit details
    Browse the repository at this point in the history