Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using multiple CLI::color() in CLI::write() outputs strings with wrong color #5893

Merged
merged 10 commits into from
Apr 18, 2022
Merged

fix: using multiple CLI::color() in CLI::write() outputs strings with wrong color #5893

merged 10 commits into from
Apr 18, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 13, 2022 •
edited
Loading

Description
Fixes #5892

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 13, 2022
@kenjis kenjis changed the title fix: multiple CLI::color() inside CLI::write() output wrong color of strings fix: using multiple CLI::color() in CLI::write() outputs strings with wrong color Apr 13, 2022
@kenjis kenjis mentioned this pull request Apr 13, 2022
Closed
@kenjis kenjis added the breaking change Pull requests that may break existing functionalities label Apr 13, 2022
paulbalandan
paulbalandan reviewed Apr 17, 2022
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this a breaking change?

system/CLI/CLI.php Outdated
Comment on lines 476 to 479
if ($text === '') {
return $text;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can combine this with the first if?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

system/CLI/CLI.php Outdated
}

return $string . $text . "\033[0m";
return $string . ($text . "\033[0m");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the need for parenthesis?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems rector added.
Removed.

@kenjis
Copy link
Member Author

kenjis commented Apr 17, 2022

I added docs.

@kenjis kenjis merged commit 93bc65e into codeigniter4:develop Apr 18, 2022
@kenjis kenjis deleted the fix-cli-color branch April 18, 2022 10:09
@kenjis
Copy link
Member Author

kenjis commented Apr 18, 2022

@paulbalandan Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Multiple CLI::color inside CLI::write change color of strings that shouldn't be affected
2 participants
@kenjis @paulbalandan