-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: enable code coverage. #5928
Conversation
@datamweb Thank you for updating. In this PR, you have two commits, but one commit is enough for this change. |
We can just squash on merge. |
@kenjis Thanks for the link. I think I did it. |
@@ -295,6 +295,8 @@ the array's values are the values to save for that key: | |||
|
|||
.. literalinclude:: model/015.php | |||
|
|||
You can retrieve the last inserted row's primary key using the ``getInsertID()`` method. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenjis Thanks for the link. I think I did it.
Yes, you did it!
But this file change has nothing to do with this PR.
You squashed unrelated previous? commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!!,I do not know why this change was applied.
Do I close this PR and open a new PR?
Try this:
|
|
@datamweb Did you use Try:
|
I recommend you never use |
I'm really tired. I am suffocating in a world of new information. Thanks for link. |
Unfortunately, some people are unable to complete Pull Requests because they cannot use git properly. But don't worry, git is not an easy tool, and it usually takes time to learn. |
@kenjis Please check, did I do it right or not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@datamweb You did it! Perfect! 👍 |
Explain about the activation
coverage
that is required to run the unit test.