Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reverse Routing does not take into account the default namespace #5936

Merged
merged 4 commits into from
May 1, 2022
Merged

fix: Reverse Routing does not take into account the default namespace #5936

merged 4 commits into from
May 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 29, 2022 •
edited
Loading

Description
Fixes #5042 (comment)
Fixes #5934

The following code does not work now.

$routes->get('users/(:num)/gallery(:any)', 'Galleries::showUserGallery/$1/$2');
$match = $routes->reverseRoute('Galleries::showUserGallery', 15, 12);

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
docs: add note
1fab815
@kenjis
fix: reverseRoute() does not take into account the default namespace
2a585bf
@kenjis
docs: fix incorrect sample
83720c7 
By default, 'App\Controllers\Galleries::showUserGallery/$1/$2' means 'App\Controllers\App\Controllers\Galleries::showUserGallery/$1/$2'.
@kenjis
docs: add note
0e060c8
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 29, 2022
@kenjis kenjis mentioned this pull request Apr 29, 2022
Closed
@kenjis kenjis merged commit ba6fddc into codeigniter4:develop May 1, 2022
@kenjis kenjis deleted the fix-reverse-routing-default-namespace branch May 1, 2022 23:42
@kenjis kenjis mentioned this pull request Jun 10, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: url_to() is not fully explained. Bug: url_to() does not take into account the default namespace
2 participants
@kenjis @paulbalandan