Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new improved auto router spark routes command #5953

Merged
merged 8 commits into from
May 7, 2022
Merged

feat: new improved auto router spark routes command #5953

merged 8 commits into from
May 7, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 3, 2022 •
edited
Loading

Description
Follow-up #5889

  • spark routes update

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the new feature PRs for new features label May 3, 2022
@kenjis kenjis force-pushed the feat-new-auto-router-show-routes branch from f2c4f2d to dd2ef18 Compare May 4, 2022 01:24
@kenjis kenjis force-pushed the feat-new-auto-router-show-routes branch from dd2ef18 to 5194766 Compare May 4, 2022 02:25
@kenjis kenjis changed the title feat: new improved auto router spark routes command feat: new improved auto router spark routes command May 4, 2022
MGatner
MGatner approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used the new Auto Router yet so I'm mostly looking at the tests and docs, which both look fantastic.

@kenjis kenjis merged commit 1807ede into codeigniter4:develop May 7, 2022
@kenjis kenjis deleted the feat-new-auto-router-show-routes branch May 7, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
new feature PRs for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner